Repository navigation
Fix connect ignoring server_public_key - #1079
Ishubhammohole wants to merge 1 commit into
Conversation
|
CI note: the database matrix completed its test steps successfully. All 40 matrix jobs are red only at Upload coverage; for example, Python 3.13 / MySQL 8.0 reports 987 passed, 22 skipped, 4 xfailed, then Codecov fails GPG verification with "No public key". The final aggregate check consequently fails too. Separately, pre-commit.ci crashes inside the existing pyupgrade 3.21.0 hook on Python 3.14: tokenize.cookie_re.match(token.src) raises TypeError: cannot use a bytes pattern on a string-like object. The hook configuration is unchanged. Flake8, distribution build, documentation, and CodeQL passed. Tooling/dependency changes are intentionally outside this focused fix. |
|
Summary
server_public_keyargument throughconnect()toConnection, so it is available before authentication starts.await connect()andasync with connect(), with supplied and omitted keys on asyncio and uvloop. Only network connection setup is replaced in these tests.Testing
.venv/bin/pytest -q tests/test_connection.py -k test_connect_server_public_key --tb=short: 8 passed; before the fix, 4 failed and 4 passed..venv/bin/flake8 aiomysql tests examples: passed.git diff --check: passed.docker infocannot connect to the Docker daemon, and no isolated test database was available. No claim of live-server authentication testing.Prepared with Codex assistance.
Fixes #670