You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix possible buffer overflow in computeDshotDMA function - #300
looks good.. i will merge this before the next release. The programming instructions are missing the first step. The command to enter the mode should be here too.
The function can be called by other parts of the code. not just in main.c
I would prefer to not have the function description at all here. Then there are two parts we have to maintain if changes are made but if its helpful and short then its ok. we don't need to repeat the dshot specifications here really.
looks good.. i will merge this before the next release. The programming instructions are missing the first step. The command to enter the mode should be here too. The function can be called by other parts of the code. not just in main.c I would prefer to not have the function description at all here. Then there are two parts we have to maintain if changes are made but if its helpful and short then its ok. we don't need to repeat the dshot specifications here really.
Thank you for feedback.
Added step 0 and removed from doc comment everything else shortening it to bare minimum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.