Repository navigation
fix: validate domain for every auth mode - #1429
Open
amitsingh05667 wants to merge 4 commits into
Open
amitsingh05667 wants to merge 4 commits into
amitsingh05667 wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 89.41% 89.47% +0.05%
==========================================
Files 448 449 +1
Lines 22777 22784 +7
Branches 10822 10823 +1
==========================================
+ Hits 20367 20386 +19
+ Misses 2410 2398 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
amitsingh05667
changed the title
… add port handling
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
validateDomain()insrc/management/wrapper/domain.ts, called frombuildManagementBaseUrl()andTokenProvider.ManagementClient,createManagementAuth, andTokenProvidernow check the domain at construction in every auth mode.domainmust be a bare hostname; a port is allowed. Missing or empty values, whitespace, and/ \ ? # @throw.domainsection ofv7_MIGRATION_GUIDE.md, and format its removed-exports table with prettier.Behavior change: a static-token
domainwith a path (such as a proxy prefix) or a trailing newline now throws at construction.Testing
src/management/tests/unit/domain-validation.test.ts, covering every auth mode forManagementClientandcreateManagementAuth, plusTokenProvider.yarn buildandyarn testpass.