Skip to content

Added translations - #70

Merged
Helias merged 1 commit into
azerothcore:masterfrom
AldebaraanMKII:master
Oct 10, 2026
Merged

Helias merged 1 commit into
azerothcore:masterfrom
AldebaraanMKII:master

Conversation

@AldebaraanMKII

@AldebaraanMKII AldebaraanMKII commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Localization
    • Added Korean, French, German, Simplified Chinese, Traditional Chinese, and Russian translations for loot module messages. Existing Spanish translations remain.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 439cf366-2e2e-4207-a6d4-96a0c3760213

📥 Commits

Reviewing files that changed from the base of the PR and between 57279b6 and eaa554d.


📒 Files selected for processing (1)
  • data/sql/db-world/base/aoe_loot_module_string.sql

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The module string locale seed adds translations for message IDs 1–8 in Korean, French, German, Simplified Chinese, Traditional Chinese, and Russian. Existing Spanish (Spain and Mexico) entries remain.

Changes

Locale seed

Layer / File(s) Summary
Add locale translations
data/sql/db-world/base/aoe_loot_module_string.sql
Adds translations for message IDs 1–8 in six locales. Retains the existing Spanish entries.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature


Merge Risk: ⚪ Minimal · up to eaa55

The added translations use the declared message IDs, and no concrete merge-blocking behavior is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check Warning The pull request has no description. It does not include the required changes, issues, source, tests, or testing steps sections. Add a description that follows the repository template. Document the added locales and message IDs, related issues, source references, tests performed, and step-by-step testing instructions.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the main change: adding translations to the loot module.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Helias
Helias merged commit 44486b1 into azerothcore:master Oct 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants