[tylerbrowndev]

kamal app exec --skip-hooks ... still runs the pre-connect hook.

#1754 (for #1752) added unless options[:skip_hooks] to pre_connect_if_required. That covers commands on Main (kamal deploy --skip-hooks works), but when a class option is given after a subcommand, Thor only puts it in the subcommand's class options. options[:skip_hooks] stays false there, both in pre_connect_if_required and in run_hook. options_with_subcommand_class_options was added for exactly this case (1f83b5f), but the hook checks don't use it.

The existing exec tests call Kamal::Cli::App directly, where the flag does land in options, so they pass either way.

Reproduction (2.12.0 and main)

With exec stubbed to print what it sees:

Command	options[:skip_hooks]	options_with_subcommand_class_options[:skip_hooks]
kamal deploy --skip-hooks / -H	true	—
kamal app exec --skip-hooks ... (any position) / -H	false	true

We hit this from a pre-deploy hook that runs a nested kamal app exec --skip-hooks -d production --roles cron ...: the nested Kamal ran pre-connect again.

Change

• skip_hooks? reads the flag through options_with_subcommand_class_options; run_hook and pre_connect_if_required use it.
• Two tests in test/cli/app_test.rb run exec through Kamal::Cli::Main, the way the CLI invokes it: without the flag pre-connect runs, and with --skip-hooks it doesn't. The second fails on main.

bin/test locally: the new tests pass and the run has the same failures as main (the Docker integration tests and the builder tests that need a Docker daemon, which this machine doesn't have).

🤖 Generated with Claude Code

[Copilot]

🟢 Approved

No active review issues were identified for the fix to honor --skip-hooks after subcommands.

No open issues 🎉

What changed in this PR

Fixes --skip-hooks handling after a subcommand so commands such as kamal app exec --skip-hooks correctly suppress hooks, including pre-connect.

Changes:

• Adds a shared skip_hooks? helper that reads merged subcommand class options and is used by both hook checks.
• Adds regression tests through Kamal::Cli::Main to verify that pre-connect runs normally and is skipped when requested.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File	Description
test/​cli/​app_test.rb	Tests hook behavior through the main CLI entry point.
lib/​kamal/​cli/​base.rb	Uses merged subcommand options when deciding whether to skip hooks.

_{Review effort: Balanced}