Repository navigation
Conversation
With --continue-on-error, a task whose process failed to spawn (e.g. ENOENT for the npm path) was dropped without recording the error, so the run resolved and the CLI exited 0 even though no task ran. Record the error and keep running the remaining tasks, so the run rejects at the end like it does for tasks that exit with a non-zero code.
Owner
|
Looks acceptable from a quick skim |
Author
|
The one red job (windows-latest, Node 24) is |
Owner
|
Unfortunately there seems to be some kind long running windows race condition. I haven't been able to identify it. Sometimes ci needs to re-run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #267
With
--continue-on-error, the rejection handler inlib/run-tasks.jsdropped spawn errors (for examplespawn /nonexistent/npm ENOENT) without storing them, sodone()resolved and the CLI exited 0 even though no task ran.The handler now records the error before deciding whether to abort. Without
-c(or with--race) nothing changes. With-cthe remaining tasks still run, and the run rejects at the end, the same way it does when a task exits with a non-zero code.Tests
Added
if tasks could not be spawned with --continue-on-errortotest/fail.js. It covers the Node API (sequential and parallel, asserting theENOENTrejection) andnpm-run-all -c,run-s -candrun-p -cwith a missing--npm-path.npm run checkand the fullnode --testsuite pass.Manual check from
test-workspace: