Repository navigation
Conversation
Contributor
|
Thanks for picking this up, and for the credit! I tried the PR (54e830d) with our ooRexx module, in place of our own compiler patch:
So once this is in a release we can drop our patch. Thanks again! |
Contributor
Author
|
Thanks for double checks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273.
call_indirectdispatch methods had fixed sizes (up to 1024 cases incall_indirect_N, blocks of 4096 ids inIndirect_N_*.apply), so on large modules they went over HotSpot's 8000-byte limit and every indirect call ran in the bytecode interpreter. Their size now comes fromendive.hugeMethodLimit, asMachine.calldispatch already does: 128 cases and blocks of 512 at the default limit, the values measured in #273.This also fixes two bugs on the block path, which this change makes much more common:
applyloaded arguments by parameter index instead of JVM slot, so a type with ani64/f64parameter before the last one failed verification. Onmainthis already affects modules with more than 1024 functions of such a type.loadChunkedClass, halved onClassTooLargeException, was ignored.int(int)functionsThanks @JosepMariaBlasco and @ddsimoes for the reproducers and the numbers.