Repository navigation
Conversation
Pins github.com/coder/envbuilder to stirby/security-rollup (38799a3) and mirrors envbuilder's resolved requirements, replaces and excludes so both modules build the same graph. terraform-plugin-framework moves to v1.19.0 and terraform-plugin-testing to v1.16.0 because coder/coder v2.37.3 needs terraform-plugin-go v0.31.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps envbuilder to the security rollup in coder/envbuilder#534 and brings the provider's dependency graph in line with it. The provider imports envbuilder as a library for
envbuilder_cached_image, so it runs the same clone and registry code on the provisioner, with the template's Git and registry credentials.govulncheck (source mode, reachable findings): 75 on
main, 8 on this branch. These are the same 7 that remain in envbuilder (buildkit, moby/go-archive, docker/docker, docker-credential-acr-env), plus grpc GO-2026-6443 (fixed in v1.83.2), which is intentionally not included.Important
github.com/coder/envbuilderis pinned to an unmerged commit (7d9f058). Re-pin to the merged commit or release tag after coder/envbuilder#534 lands, then merge this.Changes:
github.com/coder/envbuilderv1.1.0 to7d9f058(coder/coder v2.37.3, serpent v0.15.0, Go 1.26.5 with toolchain go1.26.6).replacedirectives (kaniko fork, tailscale, netlink) andexcludeblock. Without them,go mod tidyfails with ambiguousmoby/moby/apiimports.terraform-plugin-frameworkv1.11.0 to v1.19.0 andterraform-plugin-testingv1.10.0 to v1.16.0, because coder/coder v2.37.3 requiresterraform-plugin-gov0.31.0.install-mode: goinstall), because prebuilt v1 binaries refuse Go 1.26 modules.t.Context()in one test, for theusetestinglint that applies now that the Go version is above 1.24.The provider sets options from
extra_envwithopt.Setdirectly, so serpent's empty-env change does not affect it.Validation:
go build,go vet,golangci-lint run,go generate ./...with no diff, andTF_ACC=1 go test ./internal/provider/against the local registry (18 passed, 87.1% coverage).Note
TestAccCachedImageResourceis flaky in CI. The fixture step that seeds the cache withghcr.io/coder/envbuilder-preview:latestsometimes fails to clone from the test SSH server ("unable to fetch packfile"). The same failure happens onmainwith only the lint fix applied (1 of 10 jobs; 6 of 25 on this branch). It never reproduced locally in 8 full runs.