Repository navigation
fix(erc20): check transfer receipt status and keep hash on receipt errors - #1610
Open
ninglinLiu wants to merge 1 commit into
Open
ninglinLiu wants to merge 1 commit into
ninglinLiu wants to merge 1 commit into
Conversation
…rors Viem resolves reverted receipts without throwing, so transfer was reporting success after a mined revert. Also separate receipt lookup from send so an RPC receipt failure still returns the hash and the agent does not double-pay. Fixes coinbase#1558 Fixes coinbase#1547 This PR was prepared with AI assistance and reviewed/tested by the author.
🟡 Heimdall Review Status
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transferwhen the mined receipt status isreverted/failed/0(Viem does not throw on revert).sendTransactionso an RPC receipt failure still returns the transaction hash and the agent does not retry/double-pay.Fixes
Fixes #1558
Fixes #1547
Test plan
jest src/action-providers/erc20/erc20ActionProvider.test.ts(32 passed), including new cases for reverted status and receipt-lookup failure.This PR was prepared with AI assistance and reviewed/tested by the author.