Skip to content

Skip exposure service patch while suspended - #922

Merged
WalBeh merged 1 commit into
masterfrom
wb/exposure-change-suspended
Oct 22, 2026
Merged

WalBeh merged 1 commit into
masterfrom
wb/exposure-change-suspended

Conversation

@WalBeh

@WalBeh WalBeh commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

Suspend deletes the data service, so changing spec.cluster.exposure on a suspended cluster made patch_service_exposure fail with a 404 and reported the update as failed. Resume already recreates the service from the current spec, so a missing service now means there is nothing to patch. Found while reviewing #920.

Checklist

  • Link to issue this PR refers to:
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

Suspend deletes the data service, so changing spec.cluster.exposure on
a suspended cluster failed with a 404 and reported the update as
failed. Resume recreates the service from the spec, so there is
nothing to patch.

Assisted-by: Claude Code (LLM-assisted)
@WalBeh
WalBeh requested a review from tomach October 21, 2026 10:32

@tomach tomach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WalBeh
WalBeh merged commit 5fe3076 into master Oct 22, 2026
16 checks passed
@WalBeh
WalBeh deleted the wb/exposure-change-suspended branch October 22, 2026 08:23
@WalBeh WalBeh mentioned this pull request Oct 27, 2026
2 of 5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants