Repository navigation
fix: deserialize empty arrays as null for all Map and object fields - #442
Open
andrii-bodnar wants to merge 1 commit into
Open
andrii-bodnar wants to merge 1 commit into
andrii-bodnar wants to merge 1 commit into
Conversation
The API sends some empty objects as [], which broke Map-typed fields such as Project.fields, SourceString.fields, Concept.fields, Term.fields and User.fields. Configure Jackson coercion on the shared mapper so [] reads as null for every Map and POJO field, and drop the per-field EmptyArrayToNullDeserializer annotations it replaces. The deserializer class is kept and deprecated for backward compatibility. Closes #441 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
peekhovsky
approved these changes
Nov 16, 2026
yevheniyJ
reviewed
Nov 16, 2026
| * for every Map and POJO field | ||
| */ | ||
| @Deprecated | ||
| public class EmptyArrayToNullDeserializer extends StdDeserializer<Object> implements ContextualDeserializer { |
Collaborator
There was a problem hiding this comment.
do we use it anywhere? can we delete it?
yevheniyJ
approved these changes
Nov 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API sends some empty objects as
[], soMap-typed fields likeProject.fields,SourceString.fields,Concept.fields,Term.fieldsandUser.fieldsfail withMismatchedInputException. Until now we fixed this one field at a time with@JsonDeserialize(using = EmptyArrayToNullDeserializer.class), and new fields kept slipping through.Changes
cleanObjectMapperto read[]asnullfor everyMapand POJO field. Mappers created withcopy()inherit the setting, so custom deserializers get it too. Non-empty arrays still fail, andListfields are unchanged.EmptyArrayToNullDeserializerannotations, which the setting now covers.EmptyArrayToNullDeserializerinstead of removing it, for backward compatibility.cleanObjectMapperinstead of annotating fields.EmptyArrayCoercionTest, which covers the five fields from the issue,ProjectSettingsobjects, and regression checks.Closes #441
🤖 Generated with Claude Code