Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Updates incorrect setup.py links in INFO.md to use repo-relative paths so they resolve correctly when viewed from the repository.
Changes:
- Replace
http://setup.pylinks with./setup.pyin the d2l-en release checklist. - Replace
http://setup.pylinks with./setup.pyin the optional restore step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a HuggingFace datasets fallback for loading WikiText-2 when the original S3 zip URL is unavailable. Introduces _read_wiki_hf (using datasets.load_dataset('Salesforce/wikitext','wikitext-2-v1')) and wraps the existing download_extract/_read_wiki call in a try/except to fall back to _read_wiki_hf in both d2l/mxnet.py and d2l/torch.py.
abhi-cser
changed the title
…urce The previous patch only fixed d2l/mxnet.py and d2l/torch.py (library source), but CI runs notebooks from the markdown source via d2lbook. The #@save functions defined in the .md cells are what actually execute — and those still had the old bare d2l.download_extract() call with no try/except. This commit adds _read_wiki_hf() and wraps download_extract in a try/except with the HuggingFace datasets fallback directly in the bert-dataset.md source, for both mxnet and pytorch tabs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.