Skip to content

Fix Vocab.to_tokens crash on single-element index lists #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chessing234 wants to merge 1 commit into from
Closed

Fix Vocab.to_tokens crash on single-element index lists #2715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chapter_recurrent-neural-networks/text-sequence.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class Vocab: #@save
return [self.__getitem__(token) for token in tokens]

def to_tokens(self, indices):
if hasattr(indices, '__len__') and len(indices) > 1:
if isinstance(indices, (list, tuple)):
return [self.idx_to_token[int(index)] for index in indices]
return self.idx_to_token[indices]

Expand Down
2 changes: 1 addition & 1 deletion d2l/jax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@ def __getitem__(self, tokens):
return [self.__getitem__(token) for token in tokens]

def to_tokens(self, indices):
if hasattr(indices, '__len__') and len(indices) > 1:
if isinstance(indices, (list, tuple)):
return [self.idx_to_token[int(index)] for index in indices]
return self.idx_to_token[indices]

Expand Down
2 changes: 1 addition & 1 deletion d2l/mxnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ def __getitem__(self, tokens):
return [self.__getitem__(token) for token in tokens]

def to_tokens(self, indices):
if hasattr(indices, '__len__') and len(indices) > 1:
if isinstance(indices, (list, tuple)):
return [self.idx_to_token[int(index)] for index in indices]
return self.idx_to_token[indices]

Expand Down
2 changes: 1 addition & 1 deletion d2l/tensorflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ def __getitem__(self, tokens):
return [self.__getitem__(token) for token in tokens]

def to_tokens(self, indices):
if hasattr(indices, '__len__') and len(indices) > 1:
if isinstance(indices, (list, tuple)):
return [self.idx_to_token[int(index)] for index in indices]
return self.idx_to_token[indices]

Expand Down
2 changes: 1 addition & 1 deletion d2l/torch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ def __getitem__(self, tokens):
return [self.__getitem__(token) for token in tokens]

def to_tokens(self, indices):
if hasattr(indices, '__len__') and len(indices) > 1:
if isinstance(indices, (list, tuple)):
return [self.idx_to_token[int(index)] for index in indices]
return self.idx_to_token[indices]

Expand Down
Loading