Repository navigation
fix: use HTTPS DATA_URL and safe tar extraction - #2725
Closed
chessing234 wants to merge 3 commits into
Closed
chessing234 wants to merge 3 commits into
chessing234 wants to merge 3 commits into
Conversation
Move "schon" after the object phrase in the introductory translation example, matching natural German word order. Fixes #2679 Co-authored-by: Cursor <cursoragent@cursor.com>
Switch dataset downloads to HTTPS and reject path-traversal tar members when extracting archives across all d2l backend modules. Fixes #2714 Co-authored-by: Cursor <cursoragent@cursor.com>
Switch dataset downloads to HTTPS and reject path-traversal tar members when extracting archives across all d2l backend modules. Fixes #2714 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2714
DATA_URLfrom HTTP to HTTPS acrossd2l/torch.py,d2l/mxnet.py,d2l/tensorflow.py, andd2l/jax.py_safe_tar_extract()to reject path-traversal tar members (uses Python 3.12+filter='data'when available)extract()anddownload_extract()Test plan
../members are skipped on older Python versionsMade with Cursor