Repository navigation
Card shadows no longer cut off below the card row - #187
Open
coasting24 wants to merge 1 commit into
Open
coasting24 wants to merge 1 commit into
coasting24 wants to merge 1 commit into
Conversation
The strip is a scroll container (overflow-x: auto), which clips both axes, and its 6px padding cut the cards' 0 12px 32px shadow off in a hard line just below the cards. It now has room above (26px, for the 3px hover lift too) and below (48px); the extra is taken off its bottom offset, so the cards sit exactly where they were. The strip lets clicks through, only the cards catch them, so nothing under the extra room loses its clicks. Phone layout unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
coasting24
force-pushed
the
card-shadow
branch
from
November 6, 2026 06:44
0777853 to
7787bdd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The card row is a scroll container (
overflow-x: auto), which clips both axes, so its 6px padding cut the cards'0 12px 32pxshadow off in a hard line just below the cards. The strip now has room above (26px, also covers the 3px hover lift) and below (48px). The extra is taken off itsbottomoffset, so the cards sit exactly where they were. The strip itself haspointer-events: noneand the cardsauto, so nothing under the extra room loses its clicks. Phone layout unchanged.Not included: the left side. The first card's left shadow is still cut at the title line; giving the strip room there lets cards that scroll past show in that margin, which needs a different edge treatment. Happy to look at that separately if you want it.
Why?
Hard edge under every card, most visible on light photos.
Checklist
dist/hacasa-nova.jsnot committed (it is rebuilt with each release)npm run i18n:checkpassest()with an English translation (none added)dev/index.html), desktop and phone widthBefore (shadow ends in a hard line):
After:
🤖 Generated with Claude Code