Skip to content

Crtx 262557 cooc aws route53 unified aws integration - #46468

Open
oyotam wants to merge 6 commits into
masterfrom
CRTX-262557-COOC-aws-route53-unified-AWS-integration
Open

Crtx 262557 cooc aws route53 unified aws integration#46468
oyotam wants to merge 6 commits into
masterfrom
CRTX-262557-COOC-aws-route53-unified-AWS-integration

Conversation

@oyotam

@oyotam oyotam commented Nov 3, 2026

Copy link
Copy Markdown

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CRTX-262557

Description

Adds 4 Route53 commands to the unified AWS integration, to list hosted zones and DNS records and to create, update or delete records.

Must have

  • Tests
  • Documentation

oyotam added 3 commits November 3, 2026 17:29
@oyotam
CRTX-262557: Add Route53 commands to AWS COOC integration
caa8905 
Added the following commands to the unified AWS integration:
- aws-route53-hosted-zones-list
- aws-route53-hosted-zones-by-name-list
- aws-route53-resource-record-sets-list
- aws-route53-resource-record-sets-change
@oyotam
CRTX-262557: Enhance Route53 commands pagination, logging and documen…
fcaed10 
…tation

- Always write the next-page tokens to context (null on the last page)
- Rename next_marker to next_token in aws-route53-hosted-zones-list
- Return no raw response for empty results and align the messages
- Normalize hosted zone IDs by removing the /hostedzone/ prefix
- Default the limits to the API defaults (100 hosted zones, 300 record sets)
- Log only non-sensitive fields in the debug logs
- Align the YAML and README wording and the release notes
- Add unit tests for the Route53 helpers
@oyotam
CRTX-262557: Inline the Route53 record values formatting
9d88630 
Remove the single-use _record_set_values helper and build the Values column directly in aws-route53-resource-record-sets-list. The command test already covers joined values and alias DNS names.
@content-bot

content-bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions

github-actions Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AWS/Integrations/AWS
   AWS.py380228392%73, 104–108, 121, 133–134, 239–240, 574–576, 598, 1032, 1230–1231, 1266, 1367, 1400–1401, 1494–1495, 1520–1521, 1524, 1574, 1580–1581, 1633, 1867–1868, 1873–1874, 1902–1903, 2121, 2152, 2203, 2240, 2245–2246, 2274, 2317, 2322–2323, 2388, 2415, 2454, 2476, 2496–2497, 2505, 2508, 2510–2514, 2516, 2532–2535, 2544, 2548, 2550, 2554, 2572–2573, 2598–2606, 2633–2634, 2656–2657, 2713, 2715–2716, 2719–2720, 2722–2724, 2726–2731, 2733–2735, 2738–2744, 2749, 2798, 2805, 2808, 2811, 2822, 2860, 2914, 3111–3112, 3170–3171, 3252, 3303, 3310, 3359, 3419, 3615, 3637, 3644, 3674, 3699, 3711, 3810, 3818–3819, 3821, 3823–3824, 3827, 3831–3832, 3983, 3987, 3991, 4002, 4245, 4249, 4295, 4343, 4411, 4488, 4668, 4743, 5018, 5022, 5033, 5176, 5180, 5195–5196, 5233, 5387, 5427, 5500, 5550, 5611, 5983, 6066, 6069, 6071–6072, 6075, 6078, 6081, 6090, 6096, 6124, 6248, 6301, 6343, 6431, 6462, 6542, 6675, 6822, 6848, 6944, 7021, 7190, 7318–7319, 7321–7322, 7409–7410, 7450, 7674, 7779, 7837, 7904, 7954, 8030, 8095, 8134, 8201, 8257, 8284, 8342, 8446–8447, 8449–8450, 8559, 8563–8566, 8569, 8709, 8726–8730, 8756, 8821, 8886, 8940, 9002, 9057, 9111, 9238, 9344, 9360, 9493, 9526, 9555, 9589, 9621, 9763, 9781, 9846, 9874, 9937, 10000, 10034, 10114, 10159, 10247, 12175, 12177, 12179–12181, 12183, 12188, 12190–12192, 12195–12197, 12203–12204, 12206–12207, 12209–12210, 12213, 12220, 12311, 12349, 12351, 12365, 12378, 12386, 12406–12407, 12433–12434, 12451, 12456–12458
TOTAL380228392% 

Tests Skipped Failures Errors Time
920 0 💤 0 ❌ 0 🔥 13.469s ⏱️

@content-bot

This comment has been minimized.

Sign in to view
@oyotam oyotam added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Nov 4, 2026
@oyotam oyotam self-assigned this Nov 4, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Nov 4, 2026
@marketplace-ai-reviewer

marketplace-ai-reviewer commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

marketplace-ai-reviewer commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Nov 4, 2026
View reviewed changes

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for your contribution!

Overall, the changes look great, but the documentation is missing examples for the newly added Route 53 commands. Please add command examples for each new command to your examples file and regenerate the README using demisto-sdk generate-docs so the context outputs and human-readable sections are properly populated.

Once that's updated, this should be good to go!

@Moish-Gilboa, @RotemAmit, @oyotam please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/AWS/Integrations/AWS/README.md Resolved
Comment thread Packs/AWS/Integrations/AWS/README.md Resolved
Comment thread Packs/AWS/Integrations/AWS/README.md Resolved
Comment thread Packs/AWS/Integrations/AWS/README.md Resolved
@content-bot

This comment has been minimized.

Sign in to view
@oyotam
CRTX-262557: Add weight argument to aws-route53-resource-record-sets-…
8904df9 
…change, clear next-page values on empty results
@content-bot

content-bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were reported as warnings: BA131, PB130, BA132, GR109, PB131, GR101, GR107, BA133, RM108, GR103, MC101.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

This comment has been minimized.

Sign in to view
@oyotam
Merge remote-tracking branch 'origin/master' into CRTX-262557-COOC-aw…
f892800 
…s-route53-unified-AWS-integration

# Conflicts:
#	Packs/AWS/pack_metadata.json
@content-bot

content-bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

⚠️ The PR is missing the ready-for-pipeline-running label. Please add the label when the PR is ready in order to proceed.

@content-bot

content-bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: bce26583e18e1feb

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marketplace-ai-reviewer marketplace-ai-reviewer marketplace-ai-reviewer left review comments
@Moish-Gilboa Moish-Gilboa Awaiting requested review from Moish-Gilboa Moish-Gilboa is a code owner
@RotemAmit RotemAmit Awaiting requested review from RotemAmit RotemAmit is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@oyotam oyotam

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oyotam @content-bot @marketplace-ai-reviewer