[rhermida]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

[CLAassistant]

All committers have signed the CLA.

[content-bot]

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

[content-bot]

Hi @rhermida, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

[content-bot]

🤖 AI-Powered Code Review Available

Hi @kamalq97, you can leverage AI-powered code review to assist with this PR!

Available Commands:

• @marketplace-ai-reviewer start review - Initiate a full AI code review
• @marketplace-ai-reviewer re-review - Incremental review for new commits

[MosheEichler]

Hi @rhermida, Thank you for your contribution! Good work :)

Before we can start the review, the following items are missing from the PR:

1. Release notes - Add a release notes file for the new version: Packs/HashiCorp-Vault/ReleaseNotes/1_1_43.md, describing the new Using SSH Key Authentication parameter. You can generate it with demisto-sdk update-release-notes -i Packs/HashiCorp-Vault -u revision.
2. Pack version bump - Update currentVersion in Packs/HashiCorp-Vault/pack_metadata.json to 1.1.43 (the command above does this for you).
3. README - Document the new Using SSH Key Authentication parameter in the instance configuration table in Packs/HashiCorp-Vault/Integrations/HashiCorpVault/README.md, including the expected secret format (username and sshkey fields).
4. Unit tests - Add tests to HashiCorpVault_test.py covering:
   • parse_ssh_key_secret (with and without concat_username)
   • parse_legacy_secret
   • The KV1 / KV2 / CyberArk-hash fetch paths, with the SSH key option enabled and disabled, including a secret that does not contain both username and sshkey (falls back to the legacy parsing).
5. Formatting and validation - Run demisto-sdk format -i Packs/HashiCorp-Vault/Integrations/HashiCorpVault and demisto-sdk pre-commit -i Packs/HashiCorp-Vault/Integrations/HashiCorpVault and fix any issues reported.
6. PR status - The PR description is currently marked as In Progress. Once the above is done, please mark it as Ready and check the Tests and Documentation boxes.

Please feel free to reach out to me with any questions — I'm available here or on Slack :) Thanks again