Repository navigation
Conversation
MizukiTemma
self-requested a review
November 3, 2026 08:32
MizukiTemma
requested changes
Nov 3, 2026
MizukiTemma
left a comment
Member
There was a problem hiding this comment.
Thank you for opening an PR 😸
I have a small suggestion (find below).
MizukiTemma
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several UI elements that remained interactive when viewing archived places, even though archived places are intended to be read-only.
Previously, users could still open the opening-hours editor, interact with the map to modify the marker position and address information, and toggle the automatic-coordinate checkbox. Although these changes could not be saved, the interface incorrectly allowed users to initiate editing actions.
Changes Made
1. Opening hours
PlaceFormViewto pass the existing form's disabled state to the opening-hours configuration.PlaceContextMixinto use this editing permission when provided, while preserving the existing permission check as a fallback.2. Automatic coordinates checkbox
3. Map and position editing
place-map.tsto register map click and marker drag editing handlers only when editing is permitted.The map remains available for viewing and navigation.
4. Regression tests
Added parameterized tests in
test_place_form.pycovering both archived and active places.The tests verify that:
Testing
Related Issue
Closes #3524