Skip to content

4427: Fix openStreetMap when latitude is invalid - #4694

Open
bahaaTuffaha wants to merge 1 commit into
developfrom
4427-Fix-OpenStreetMap-when-latitude-is-invalid
Open

bahaaTuffaha wants to merge 1 commit into
developfrom
4427-Fix-OpenStreetMap-when-latitude-is-invalid

Conversation

@bahaaTuffaha

Copy link
Copy Markdown
Contributor

Short description

Currently the map disappears when creating a location that has an invalid latitude.

Proposed changes

  • Extended the condition in getCoordinates to create a LngLat only when latitudeInput is less or equal the the max value.

Side effects

N/A

Faithfulness to issue description and design

There are no intended deviations from the issue and design.

How to test

  • Run the server and go to places.
  • Create a new place and test the latitude with more than 90 for ex.(90.1/-90.1).
  • Test also the longitude (180.1/-180.1).

Resolved issues

Fixes: #4427


Pull Request Review Guidelines

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenStreetMap in location breaks if Latitude is below/above threshold of 90/-90

2 participants