Repository navigation
fix(call): bind group streams to relay answer and packetize EAS2 audio - #242
Merged
Merged
Conversation
# Conflicts: # packages/linejs/client/features/call/opus.test.ts # packages/linejs/client/features/call/planet/transport.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two independent causes of silent or distorted PLANET group audio: registration used locally invented stream IDs instead of the final relay allocation, and CELT group payloads omitted the EAS2 activity bitmap.
packetizeNativeGroupOpusPairs()helper: CELT EAS2 activity bitmap after TOC/count and before VBR lengths/data, MSB-first non-silence flags (including unvoiced audio), and correct two-byte VBR sizes.This is based directly on
main, independent of #241. No incoming-call implementation, auto-join policy, crypto changes, dependency changes, or account/capture artifacts.Compatibility and limitations
frameActivityis required for CELT inputs. Only complete pairs of matching mono 20 ms code-0 inputs are supported; invalid layouts throw. SILK/hybrid keep their in-band activity.groupDataSessionAfterProvisionalremains accepted for source compatibility but is deprecated and ignored.Testing
deno test -A: 357 passed, 7 steps, 0 failed.node scripts/test_node_transport.mts: 2 passed.deno check example/call/call_on_command.ts: passed.deno publish --dry-run --allow-dirtyin bothpackages/linejsandpackages/types: passed.deno fmt --checkfor changed TypeScript files andgit diff --check: passed.Checklist