Repository navigation
Build arm64 images natively instead of emulating them - #46
Merged
Merged
Conversation
Like in docker-php, every platform now builds on a native runner of its own (ubuntu-24.04 and ubuntu-24.04-arm) and pushes by digest only; a merge job combines the digests into one manifest list per PHP version and tags it in both registries. Each build job reads the PHP version from the label of the newest harbor.flownative.io/docker/php image itself and names its digest artifact after it, so if docker-php publishes a new version between the two jobs of a branch, the merge fails instead of combining images of different PHP versions. Also adds workflow_dispatch, to be able to start a build by hand. Refs OPS-8R Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same approach as flownative/docker-php#70, which brought the docker-php build from ~150 to 10 minutes.
preparedetermines the latest release tag oncebuild: matrix PHP branch × platform,linux/amd64onubuntu-24.04,linux/arm64onubuntu-24.04-arm. Each job reads the PHP version from theorg.opencontainers.image.versionlabel ofharbor.flownative.io/docker/php:<branch>(withdocker buildx imagetools inspectinstead offlownative/action-docker-get-label) and pushes by digest only.mergecombines the two digests of each PHP version into one manifest list and tags it (8.4,8.4.27) in Docker Hub and Harbor.announceis unchanged, now aftermerge.The digest artifacts are named after the PHP version each job found. Should docker-php publish a new version between the two jobs of a branch, the merge finds only one digest per version and fails instead of combining images of different PHP versions.
Also adds
workflow_dispatch, to start a build by hand.Tested:
actionlintis clean; the version step was run locally against Harbor, including a mismatching label.Test run (
workflow_dispatchon this branch, https://github.com/flownative/docker-beach-php/actions/runs/41896508784): 5 min instead of ~8. Build jobs 2–3.5 min each, merge 1 min. All tags in Docker Hub and Harbor carry amd64 and arm64, and the version label is correct.Refs OPS-8R (https://minka.flownative.com/go/card/OPS-8R)