Repository navigation
chore(response_writer): add Unwrap() method to ResponseWriter interface - #4506
Open
raju-mechatronics wants to merge 3 commits into
Open
raju-mechatronics wants to merge 3 commits into
raju-mechatronics wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4506 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 48 48
Lines 3188 3188
=======================================
Hits 3145 3145
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@appleboy is this useful? The unwrap function is already implemented. I just exposed it via the ResponseWriter interface. |
Member
|
@raju-mechatronics Please write the unit testing. |
Contributor
Author
sure. I'll add the unit tests soon and push the update. |
Contributor
Author
Added unit tests for the Unwrap() method |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
Unwrap() http.ResponseWritermethod to the exportedResponseWriterinterface.Motivation
*responseWritertype already implementsUnwrap().gin.ResponseWritercannot safely/portably call.Unwrap().http.ResponseWriterto third-party handlers/middleware (c.Writer.Unwrap())Adding it to the interface makes usage more idiomatic and type-safe.