Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4913 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 48 48
Lines 3188 3188
=======================================
Hits 3145 3145
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four existing tests fail on Windows/amd64 with Go 1.26.2 because they assume Unix permission semantics or expect a TCPListener.File error that no longer occurs. The same failures reproduce on unmodified master (
0f09c3a).Keep uploaded-file content checks on all platforms, and run the exact Unix permission check in a subtest that explicitly skips Windows. Skip the directory-search-permission failure case on Windows, where those permission bits are not enforced. Compare an existing directory's actual permissions before and after saving instead of assuming Windows reports 0700.
Require TCPListener.File to succeed and exercise the existing RunFd HTTP response checks on Windows as well. Close the listener and duplicated file when the test finishes.
No production code, dependency, or workflow changes are included.
Validation on Windows/amd64, Go 1.26.2:
go test ./... -count=1,go test ./... -count=1 -tags nomsgpack, andgo test ./... -count=1 -race: passed, without command-line skips.go vet ./...: passed.run --timeout 5m --new-from-rev upstream/master: 0 issues.Pull Request Checklist
masterbranch.docs/doc.md. (Not applicable: tests only.)Known baseline: Trivy reports five vulnerabilities in unchanged golang.org/x/net v0.57.0; the official master scan reports the same findings. The full-CI checklist item remains unchecked.