Repository navigation
fix(gin): root the trailing-slash redirect after X-Forwarded-Prefix is sanitized - #4923
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
…s sanitized Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4923 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 48 48
Lines 3188 3189 +1
=======================================
+ Hits 3145 3146 +1
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redirectTrailingSlashprepends the sanitizedX-Forwarded-Prefixto the path and never re-roots the result.sanitizePathCharskeeps only[A-Za-z0-9/-], so the prefix can come back empty or without its leading slash. Empty leavesLocation: //path, which a client reads as a host.#apileaves a relativeapi/api/path, because the client resolves it against the request path that was just rewritten. Anchoring at one leading slash fixes both, and rooted prefixes such as/apiare unaffected. Three assertions inTestRouteRedirectTrailingSlashheld the old values, so I updated them and added the empty-prefix case.