Skip to content

Take the CI Go version from go.mod - #322

Open
paskal wants to merge 1 commit into
go-pkgz:masterfrom
paskal:ci/go-version-from-go-mod
Open

paskal wants to merge 1 commit into
go-pkgz:masterfrom
paskal:ci/go-version-from-go-mod

Conversation

@paskal

@paskal paskal commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Previously, the workflows pinned the Go version in actions/setup-go separately from go.mod. After this change, CI reads the major and minor version from the go directive in go.mod and installs the latest patch release of it with check-latest: true. go-version-file would install exactly the patch version written in go.mod, such as 1.25.0, so it is not used. go.mod is unchanged.

build reads go.mod, and build-v2 reads v2/go.mod. Both declare go 1.25.0, so CI moves from Go 1.26 to the latest 1.25 patch release.

On this branch, build and build-v2 install Go 1.25.14 and pass.

CI pinned its Go version separately from go.mod. It now reads the major
and minor version from the go directive and installs the latest patch
release of it.

Each workflow reads its own module's go.mod. Both declare go 1.25.0, so
CI moves from Go 1.26 to the latest 1.25 patch release.
@paskal
paskal requested a review from umputun as a code owner November 1, 2026 10:32
@coveralls

coveralls commented Nov 1, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 41297945154

Coverage remained the same at 86.88%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3849
Covered Lines: 3344
Line Coverage: 86.88%
Coverage Strength: 9.95 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants