Skip to content

Check reconstructed layouts against compiler layout queries - #3860

Open
joshlf wants to merge 1 commit into
Gxizdpw52bljtxjfng3ervgk5xnca6mowfrom
Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3
Open

joshlf wants to merge 1 commit into
Gxizdpw52bljtxjfng3ervgk5xnca6mowfrom
Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3

Conversation

@joshlf

@joshlf joshlf commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Reconstructed layouts must agree with rustc's objects. Check that boundary
for ordinary, aligned, and packed repr(C) fixtures: compile-time assertions
compare complete size, alignment, and field offsets. Nested DST fixtures
safely unsize real array tails and compare the metadata-size calculation
with size_of_val.

The checks cover the selected compiler, target, and concrete instantiations;
they do not establish a universal result across types or compilers. MSRV
runtime comparisons remain available where layout queries are not yet const.

Authored by an AI agent acting on joshlf's behalf.


Latest Update: v17 — Compare vs v16

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v17 v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v16 v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v15 v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v14 v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v13 v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v12 v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v11 v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v10 v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v9 v8 v7 v6 v5 v4 v3 v2 v1 Base
v8 v7 v6 v5 v4 v3 v2 v1 Base
v7 v6 v5 v4 v3 v2 v1 Base
v6 v5 v4 v3 v2 v1 Base
v5 v4 v3 v2 v1 Base
v4 v3 v2 v1 Base
v3 v2 v1 Base
v2 v1 Base
v1 Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3 && git checkout -b pr-Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3 FETCH_HEAD

Checkout

git fetch origin refs/heads/Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3

Stacked PRs enabled by GHerrit.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T21:40:57.870906Z 8a19719 PR opened
🔒 Security Review ✅ Completed 2026-10-13T21:35:18.948573Z 8a19719 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@joshlf
joshlf force-pushed the Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3 branch from 8a19719 to 7853cde Compare October 14, 2026 03:39
@joshlf
joshlf force-pushed the Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3 branch from 7853cde to 3993d61 Compare October 14, 2026 18:32
@joshlf
joshlf force-pushed the Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3 branch from 3993d61 to fe21a89 Compare October 14, 2026 21:43
@joshlf
joshlf changed the base branch from main to Gxizdpw52bljtxjfng3ervgk5xnca6mow October 14, 2026 21:43
@joshlf
joshlf force-pushed the Gxizdpw52bljtxjfng3ervgk5xnca6mow branch from a1106d8 to b593edb Compare October 15, 2026 00:40
@joshlf
joshlf force-pushed the Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3 branch from fe21a89 to 52c70c4 Compare October 15, 2026 00:40
Reconstructed layouts must agree with rustc's objects. Check that boundary
for ordinary, aligned, and packed repr(C) fixtures: compile-time assertions
compare complete size, alignment, and field offsets. Nested DST fixtures
safely unsize real array tails and compare the metadata-size calculation
with size_of_val.

The checks cover the selected compiler, target, and concrete instantiations;
they do not establish a universal result across types or compilers. MSRV
runtime comparisons remain available where layout queries are not yet const.

Agent-authored-by: AI agent acting on joshlf's behalf
gherrit-pr-id: Gkxoay4mfhudcnfy2cuk46iu6gnltvxg3

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants