Skip to content

fix(cabal-install): drop deprecated new-command completions - #12450

Open
KeuqS wants to merge 1 commit into
haskell:masterfrom
KeuqS:fix/remove-deprecated-new-completions
Open

KeuqS wants to merge 1 commit into
haskell:masterfrom
KeuqS:fix/remove-deprecated-new-completions

Conversation

@KeuqS

@KeuqS KeuqS commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove bash completion entries for the deprecated new-build, new-repl, new-run, new-test, new-bench, and new-haddock commands
  • keep the existing new-install completion entry unchanged
  • add a changelog entry for the user-visible completion change

Closes #12151

QA Notes

  • Completion requests for the six deprecated new-* commands no longer enter the target-list completion path.
  • new-install continues to use executable target completion.

Validation

  • git diff --check
  • verified the deprecated completion entries are absent and new-install remains present
  • shellcheck and the Bash 3 compatibility check could not be run locally because Bash/ShellCheck are not installed on the Windows host

Checklist

  • The change is recorded in changelog.d/12151.md.
  • QA notes are included above.
  • Automated tests have not been added; this repository has no test harness for this completion script.

@KeuqS
KeuqS force-pushed the fix/remove-deprecated-new-completions branch from 1c072a0 to 64c8241 Compare October 11, 2026 23:20
[ "$Completion" == new-bench ] && _cabal_list_targets "benchmark" && break
[ "$Completion" == new-haddock ] && _cabal_list_targets && break

[ "$Completion" == new-install ] && _cabal_list_targets "executable" && break

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove this one?

@Bodigrim

Copy link
Copy Markdown
Collaborator

Please apply "AI-assisted" label. Please use a relevant PR template.

  • shellcheck and the Bash 3 compatibility check could not be run locally because Bash/ShellCheck are not installed on the Windows host

Honestly, I don't find proxying unfiltered AI responses helpful.

@ulysses4ever ulysses4ever left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that there PR template should have been preserved and that the description should have been proofread before posting. At the same time I recognize that it is a low-cost minor cleanup that I don’t want to hold on those grounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we still need bash completion for new-* commands?

4 participants