Repository navigation
Conversation
KeuqS
force-pushed
the
fix/remove-deprecated-new-completions
branch
from
October 11, 2026 23:20
1c072a0 to
64c8241
Compare
Mikolaj
reviewed
Oct 14, 2026
| [ "$Completion" == new-bench ] && _cabal_list_targets "benchmark" && break | ||
| [ "$Completion" == new-haddock ] && _cabal_list_targets && break | ||
|
|
||
| [ "$Completion" == new-install ] && _cabal_list_targets "executable" && break |
Collaborator
|
Please apply "AI-assisted" label. Please use a relevant PR template.
Honestly, I don't find proxying unfiltered AI responses helpful. |
ulysses4ever
approved these changes
Oct 20, 2026
ulysses4ever
left a comment
Collaborator
There was a problem hiding this comment.
I agree that there PR template should have been preserved and that the description should have been proofread before posting. At the same time I recognize that it is a low-cost minor cleanup that I don’t want to hold on those grounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new-build,new-repl,new-run,new-test,new-bench, andnew-haddockcommandsnew-installcompletion entry unchangedCloses #12151
QA Notes
new-*commands no longer enter the target-list completion path.new-installcontinues to use executable target completion.Validation
git diff --checknew-installremains presentshellcheckand the Bash 3 compatibility check could not be run locally because Bash/ShellCheck are not installed on the Windows hostChecklist
changelog.d/12151.md.