Repository navigation
fix(reg-exp-router): support line terminators in route paths for v5 - #5547
Merged
Merged
Conversation
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
Reported by octocov |
HTTP Performance Benchmark
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v5 #5547 +/- ##
=====================================
Coverage ? 79.93%
=====================================
Files ? 131
Lines ? 10151
Branches ? 2237
=====================================
Hits ? 8114
Misses ? 2037
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 tasks done
yusukebe
approved these changes
Oct 10, 2026
Member
This is great! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5345.
This is the v5 version of #5524.
v5 already rejects custom parameter patterns that match an empty string. That prevents collisions with the wildcard patterns, so the fix only needs updated wildcard expressions and the tokenizer's
sflag.Compared with v5 at
6465a911, the minified bundle size increases by 27 bytes (18,636 → 18,663 bytes).The author should do the following, if applicable
pnpm run check:fixto format and lint the code