Skip to content

feat: direct download mode on disable_seeding, season-stripped library folders, per-anime settings, etc - #42

Closed
Omena0 wants to merge 8 commits into
icarosuper:masterfrom
Omena0:master
Closed

Omena0 wants to merge 8 commits into
icarosuper:masterfrom
Omena0:master

Conversation

@Omena0

@Omena0 Omena0 commented Sep 20, 2026 •

Copy link
Copy Markdown

fixes #41 and #40

@Omena0

Omena0 commented Sep 20, 2026

Copy link
Copy Markdown
Author

imma add a bunch of other stuff while im at it

@Omena0 Omena0 mentioned this pull request Sep 21, 2026
@Omena0 Omena0 changed the title feat: webhook language field + translated Priorities page feat: A bunch of things Sep 21, 2026
@Omena0

Omena0 commented Sep 21, 2026

Copy link
Copy Markdown
Author

"Other things" such as:

  • Option to disable seeding entirely
  • Seeding upload limit (mbps)
  • Seeding total upload limit (MB)
  • Seeding time limit (hours) (how long after downloading to seed it for)
  • Webhook Anime ID and hash
  • Some things from the TODO list

…d folder override, disable seeding, season-based library folders, batch episode delete/redownload, anime debug API endpoint, and next airing status filter
@Omena0 Omena0 changed the title feat: A bunch of things feat: direct download mode on disable_seeding, season-stripped library folders, per-anime settings, etc Oct 17, 2026

@Omena0 Omena0 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Other things" such as:

  • Option to disable seeding entirely
  • Seeding upload limit (mbps)
  • Seeding total upload limit (MB)
  • Seeding time limit (hours) (how long after downloading to seed it for)
  • Webhook Anime ID and hash
  • Some things from the TODO list

didnt add everything here but i think its fine

@Omena0

Omena0 commented Oct 23, 2026

Copy link
Copy Markdown
Author

I will still be adding more fixes but you can review / make changes if you want.
For example currently it still doesn't properly stop downloading series that already are in the library.

@Omena0
Omena0 marked this pull request as ready for review October 23, 2026 01:14
@icarosuper

Copy link
Copy Markdown
Owner

Yo, sorry for not answering before, I just saw your PR today.
Thanks a lot for the help!! I'll check it out soon.

@Omena0

Omena0 commented Oct 31, 2026

Copy link
Copy Markdown
Author

Yo, sorry for not answering before, I just saw your PR today.
Thanks a lot for the help!! I'll check it out soon.

Yeah no problem, this branch is still pretty buggy, mostly regarding the library. Sometimes seasons download in the wrong folders or the file rename doesn't apply. Haven't had much time to investigate though.

@icarosuper

Copy link
Copy Markdown
Owner

Hey @Omena0, thanks a lot for this PR, and for opening #40 and #41. There was a lot of useful stuff in here. The branch was 87 commits behind master, and several commits mixed unrelated changes, so I couldn't merge or cherry-pick it as is. Instead I reworked the parts that fit on top of the current code. Here's what landed:

  • AniList pagination (0f634c8). The list queries now follow hasNextPage, so accounts with more than 50 entries in a status no longer lose the rest. It also covers the custom-lists query, and if a page fails the whole fetch falls back to the cache instead of returning a partial list.
  • Dotted keys in config set (4bf20ef), e.g. config set notifications.batch_window_seconds 30.
  • Webhook messages (46c11f9). Consecutive episodes collapse into one line ("EPs 1-24"), and there are new {{anime_id}} / {{torrent_hash}} variables.
  • Webhook preview + debug through the API (766474f). The preview renders the preset from the request body, so unsaved forms work too. Debug is POST /animes/{id}/debug with animes debug <id> in the CLI.
  • Batch delete/redownload (47b1b39). Deleting the selection is now one request, which also fixes packs staying on disk when their episodes were deleted in parallel.
  • disable_seeding, fixes allow to disable seeding #40 (6720b0d). Removing the torrent after organize stops seeding, but BitTorrent still uploads while it downloads. So with this option the session never uploads at all (no unchoking, empty allowed-fast set), and each torrent is removed together with its download copy once it's in the library.

#41 was already fixed on master: the Priorities page is translated, and webhooks are sent in English now.

What I left out, and why:

  • Season-stripped library folders. The project uses one folder per AniList entry on purpose (decisions #45), and renaming would move new episodes away from existing libraries.
  • Skip-if-in-library in episode selection. It ran before the delete checks, so organized episodes would never be deleted by status or watched rules.
  • Webhook retry. The request body was consumed on the first try, so retries went out empty. And for the 429 case, sending fewer messages (the batch window) is what helps.
  • Per-anime webhooks / download folder. The webhook filter leaked between animes within a batch window, and the folder override wasn't read anywhere yet. Happy to revisit these if there's demand.
  • Webhook language, standalone import/export, build/CI changes. Out of scope for now.

Thanks again! I'll close this PR since its contents are now on master in this reworked form.

@icarosuper icarosuper closed this Nov 5, 2026
@Omena0

Omena0 commented Nov 5, 2026

Copy link
Copy Markdown
Author

Alright, thanks. This PR was a mess tbh. Mostly due to me using garbage AI models so I apologize for you having to rework it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incomplete translations for webhook messages and priorities page

2 participants