Skip to content

Merge master into version-1 - #102

Merged
suryakantkamble merged 4 commits into
version-1from
master
Oct 13, 2026
Merged

suryakantkamble merged 4 commits into
version-1from
master

Conversation

@suryakantkamble

@suryakantkamble suryakantkamble commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

What changed & why

Summary of changes:
Merges master into version-1, bringing in four commits that exist only on master:

  • Attachments in comments: Adds comment.py handling so files referenced in a comment's content are encoded and re-saved with the comment. Also updates ia_support_tickets.js to match (3 lines changed).
  • Packaging: Adds setup.py so the app can be installed as a Python package. It reads dependencies from requirements.txt and takes its version from iassist.__version__.
  • requirements.txt: Added as an empty file.

Type of change:

  • Bug fix
  • New feature / enhancement
  • Configuration change (DocType, field, workflow, print format, etc.)
  • Refactor / code cleanup
  • Other (describe below):
    packaging (setup.py, requirements.txt) added

Risk & impact

Which modules / doctypes are affected?
Comment handling (custom_script/comment/comment.py), Support Tickets client script (ia_support_tickets.js), and app packaging.

Could this break any existing functionality?

  • No impact on existing behaviour
  • Low risk — minor change, isolated area
  • Medium risk — touches shared logic or multiple doctypes
  • High risk — core workflow, permissions, or data migration involved

Has this been tested on a staging / demo site?

  • Yes
  • No (explain why below)

Testing evidence

Test cases written?

  • Yes — test cases have been written and are passing
  • Not applicable for this change (explain below)

How was this manually tested?

  • bench migrate runs with no errors
  • Manual comment attachment tests (author and other user view)
  • pip install -e . (blocked until requirements.txt is filled)

Task completion checklist

Before marking this PR as ready for review, confirm the following:

  • Code follows the project's coding conventions and Frappe framework patterns
  • No hardcoded values, credentials, or environment-specific config left in the code
  • All custom fields / doctypes have proper naming (no test or temp names)
  • bench migrate has been run and no errors thrown
  • No console.log, print, or debug statements left in the code
  • Relevant permissions have been checked (roles, field-level permissions)
  • If a background job or scheduler is involved, it has been tested end-to-end
  • Release notes have been updated for this change
  • PR title clearly describes the change (not "fix" or "update") Follow convention
  • This PR is focused — it does one thing and does not bundle unrelated changes

Reviewer notes

  • Fill requirements.txt with requests and make setup.py skip blank lines.
  • Confirm whether attachments should be public or private.
  • Decide whether failed attachments should show a warning or block the comment.

@suryakantkamble
suryakantkamble merged commit 6c6c981 into version-1 Oct 13, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants