Repository navigation
Merge master into version-1 - #102
Merged
Merged
Conversation
…previe fix: attachment in comment functionality
fix: setup.py file added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed & why
Summary of changes:
Merges
masterintoversion-1, bringing in four commits that exist only onmaster:comment.pyhandling so files referenced in a comment's content are encoded and re-saved with the comment. Also updatesia_support_tickets.jsto match (3 lines changed).setup.pyso the app can be installed as a Python package. It reads dependencies fromrequirements.txtand takes its version fromiassist.__version__.requirements.txt: Added as an empty file.Type of change:
packaging (
setup.py,requirements.txt) addedRisk & impact
Which modules / doctypes are affected?
Comment handling (
custom_script/comment/comment.py), Support Tickets client script (ia_support_tickets.js), and app packaging.Could this break any existing functionality?
Has this been tested on a staging / demo site?
Testing evidence
Test cases written?
How was this manually tested?
bench migrateruns with no errorspip install -e .(blocked untilrequirements.txtis filled)Task completion checklist
Before marking this PR as ready for review, confirm the following:
bench migratehas been run and no errors thrownconsole.log,print, or debug statements left in the codeReviewer notes
requirements.txtwithrequestsand makesetup.pyskip blank lines.