Skip to content

ci: docker push develop to ghcr.io - #32

Merged
olivhoenen merged 5 commits into
iterorganization:developfrom
Louwrensth:feature/ci-publish-nightly-image
Oct 1, 2026
Merged

olivhoenen merged 5 commits into
iterorganization:developfrom
Louwrensth:feature/ci-publish-nightly-image

Conversation

@Louwrensth

@Louwrensth Louwrensth commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Hereby, we provide Docker images tagged with:

  • ":develop" : single moving tag that follows develop.
  • ":latest" : single moving tag that follows main (a.k.a. "stable").
  • ":" : static tags for every push to develop or tags

We assume a conventional flow, where:

  • Ordinary PRs are toward develop.
  • Releases are PRs of develop into main, shadowing develop.
  • Tags should be exclusively be on main.

Hereby, we provide docker images tagged with:
- "nightly" : single moving tag that follows merges in develop
- `git-describe` : fixed tags, one for every merge since PR#27
- "latest" : single moving tag that follows latest tagged commit (main)
@Louwrensth Louwrensth self-assigned this Sep 24, 2026
@Louwrensth Louwrensth added the github_actions Pull requests that update GitHub Actions code label Sep 24, 2026

@SimonPinches SimonPinches left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Nightly" is a slightly misleading name. The tag moves on every merge, not on a nightly schedule. Would develop be a better name - or is nightly just the accepted convention?
Two quick merges could race if their publish jobs finish out of order and leave nightly pointing at the older commit. A concurrency: group on the publish job would stop that.
The README doesn't mention nightly, latest or the version tags so maybe we should add a short note to help people who pull the image?

Comment thread .github/workflows/ci.yml Resolved
@Louwrensth

Copy link
Copy Markdown
Contributor Author

"Nightly" is a slightly misleading name. The tag moves on every merge, not on a nightly schedule. Would develop be a better name - or is nightly just the accepted convention?

Yes! I had the same question in my head, doubting between develop and nightly -- both seemed suggested by a nearest LLM, and since Olivier brought nightly to the table, I thought it fine. I'll switch to develop.

Two quick merges could race if their publish jobs finish out of order and leave nightly pointing at the older commit. A concurrency: group on the publish job would stop that.

When the first merge is somehow slower than the second, I see. I'll look into it and add it. 👍

The README doesn't mention nightly, latest or the version tags so maybe we should add a short note to help people who pull the image?

Yes, and also in the service files it would make sense. 👍

@Louwrensth

Louwrensth commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author

BTW, here is a test in organization "Louwrensth":

It shows:

Recent tagged image versions
nightly
test-tag
Published about 3 hours ago · Digest …
sha256:32085a9d7d695701ee90308974df285a6d31ed4b19c985d643223303d57376a5

latest
Published about 3 hours ago · Digest …
sha256:6fbb307a09571a1992402dc849a8cb82958459c74d4c35733aed6df856896e70

So these are two docker images, with three tags, based on one commit. Not super elegant.

These are the GHA jobs that published them:

Both are triggered by "push" events, (not pull-request), the first by pushing to branch develop, the second by pushing the commit. Both references just happened to point to the same commit....

Perhaps also this can be cleaned up with a concurrency limitation, provided that the second event in the queue also can check if the commit in question has already a built and published image... 😕

Update:
No need to clean this. The build with the new tag will inject a different version via APP_VERSION, so that makes the built image actually different from the same commit before the tag was present.

We can think of pruning historical images perhaps.

@Louwrensth Louwrensth changed the title ci: docker push nightly to ghcr.io ci: docker push develop to ghcr.io Sep 24, 2026
@Louwrensth

Copy link
Copy Markdown
Contributor Author

BTW, do we care that tag pushes always move the :latest docker image tag?

@olivhoenen

Copy link
Copy Markdown
Contributor

Would be better to keep only a single develop version, and the released tags of course (to limit storage on the organization level)

- remove tarball of docker image
- merge jobs, remove artefact roundtrip between jobs
- remove pull_request triggers
@olivhoenen
olivhoenen merged commit 3054f3d into iterorganization:develop Oct 1, 2026
1 check passed
@Louwrensth
Louwrensth deleted the feature/ci-publish-nightly-image branch October 1, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants