Repository navigation
ci: docker push develop to ghcr.io - #32
olivhoenen merged 5 commits into
Conversation
Hereby, we provide docker images tagged with: - "nightly" : single moving tag that follows merges in develop - `git-describe` : fixed tags, one for every merge since PR#27 - "latest" : single moving tag that follows latest tagged commit (main)
SimonPinches
left a comment
There was a problem hiding this comment.
"Nightly" is a slightly misleading name. The tag moves on every merge, not on a nightly schedule. Would develop be a better name - or is nightly just the accepted convention?
Two quick merges could race if their publish jobs finish out of order and leave nightly pointing at the older commit. A concurrency: group on the publish job would stop that.
The README doesn't mention nightly, latest or the version tags so maybe we should add a short note to help people who pull the image?
Yes! I had the same question in my head, doubting between
When the first merge is somehow slower than the second, I see. I'll look into it and add it. 👍
Yes, and also in the service files it would make sense. 👍 |
|
BTW, here is a test in organization "Louwrensth": It shows:
So these are two docker images, with three tags, based on one commit. Not super elegant. These are the GHA jobs that published them:
Both are triggered by "push" events, (not pull-request), the first by pushing to branch develop, the second by pushing the commit. Both references just happened to point to the same commit....
Update: We can think of pruning historical images perhaps. |
to avoid hypothetically moving the develop image tag to older merge
|
BTW, do we care that tag pushes always move the |
|
Would be better to keep only a single |
- remove tarball of docker image - merge jobs, remove artefact roundtrip between jobs - remove pull_request triggers
Hereby, we provide Docker images tagged with:
develop.main(a.k.a. "stable").developor tagsWe assume a conventional flow, where:
develop.developintomain, shadowingdevelop.main.