Repository navigation
Conversation
* [FIX] Typo in the id sampler for classif * [FIX][TEST] Repair a typo lam/theta on checking optcond, w/ companion test * [TEST] More coverage on samplers * [TEST][FIX] Handle better the whole shape management in wrapper * [FIX] More precise typing for some cost helper functions Also fixed some issues with type-inf costs * [CLEAN] Removed the useless full-interface Weber loss To be entirely removed later anyway. * [FIX] Make OR estimators have a reduction attribute To line up with the linear models * [CLEAN] Removed useless deprecation code snippets * [FEAT] Add n_iter option to all estimators [FIX] Aligned all error messages for guards * [FIX] Removed samples from overfitting tests to make them quicker * [FIX] Formatting for logprobs went up an abstraction level Now on the base class so that all of them get the same api * [CLEAN] Moved nnets to another save repo, see doc for NNs * [TEST] Improved test coverage by ignoring really irrelevant files Also covered some cost helpers, the dirac class, and other details * [FIX] Fixed some inside error messaging of the lib They should not be triggered, should be unreachable * [CLEAN] Removed another deprecation snippet * [FIX] Fixed small-loop issues in training helpers * [FIX] FIxed optcond to align with tests previously added * [FIX] Fixes commit on n_iter feature to change the wrapping api * [TEST] More coverage on losses * [TEST] More coverage on samplers * [CLEAN] Removed useless import * [STYLE] Removed line skips lints * [TYPING] Small error of forgotten override in base class of costs Regarding the label sampling * Remove unncessary git lfs pull in Makefile * Increase tolerance * Add coverage badge * [FIX] Adjust README for coverage * [FIX] Fixed doc link in README --------- Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr>
* [DOC] Fix some typos and citation formatting, and rephrase parts Rephrased mostly content about mixed features to clarify that we do not solve the true WDRO unlike the original authors of the cited ref * [CLEAN] Removed neural net implem in sklearn from doc Was too heavy and moved elsewhere * [DOC] Add docs on the comparison to p-dro and wilds xp * [FIX] Add good dependencies * [FIX] Another dependency set for cvxopt * [FIX] Typo in moon example * [DOC] Round of modifs on the numerical experiments * [DOC] Second round of advices from Jerome * [DOC] Incorporated advices from Filippo Especially on formats of charts
* [DOC] Attempt at fixing the compilation times for the doc * [FIX][DOC] Problem with rho keys for plots
Avoid breaking doc in case they do a major release soon
No doing weird stuff like using the bespoke "echo" command, who has echo in their computer nowadays anyway?
Rephrasing some parts of the doc
Should allow better time scaling to make compilation cheaper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is its current state after @wazizian changed it:
