Repository navigation
Fix CI: CMake 4 on Windows (benchmark minimum) and the EAThread C++20 build on Linux - #8
Merged
Merged
Conversation
CMake 4 removed compatibility with versions below 3.5, so configuring with EASTL_BUILD_BENCHMARK=ON failed on benchmark/CMakeLists.txt (VERSION 3.1), which broke every Windows job of the CI (windows-latest has CMake 4). CMake 3.31 and later also warn about versions below 3.10, which test/CMakeLists.txt (VERSION 3.5) triggered. Both now use the root's 3.11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings EAThread PR #5, which fixes the Unix build with GCC and clang in C++20; every Linux job of the CI failed on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jmgilbert2
added a commit
that referenced
this pull request
Oct 21, 2026
Brings PR #6 (GCC 10-15 warning cleanup) and PR #7 (uninitialized_fill copy-constructs unless the type is trivially copyable, upstream electronicarts#485). PR #8 only changed the benchmark and test projects and the test submodule pins, which don't apply to this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two failures of the CI (
c-cpp.yml) on master since PR #6.windows-latesthas CMake 4, which rejectsbenchmark/CMakeLists.txt'scmake_minimum_required(VERSION 3.1). The benchmark and test projects now require 3.11, like the root. That also removes the CMake 3.31+ deprecation warningtest/CMakeLists.txt(3.5) gave.char8_t(source/unix/eathread_unix.cpp). The EAThread test submodule now pins its latestno-testshead (56f3b93), which brings EAThread PR Update the EATest test submodule to the latest no-tests head #5.Verified beforehand in a scratch copy of the CI matrix (branch
ci-probe):This PR's own CI run should be green.
The other test packages' CMake deprecation warnings go away with the
cmake-3.11PRs in those repos and the pin round that follows.🤖 Generated with Claude Code