Repository navigation
Conversation
Signed-off-by: miyang <myang@juicedata.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
doResolvecalledpath.Clean(p)at the start andparentDirusedpath.Dir, which collapsed.,.., and trailing slashes lexically before walking the filesystem. This caused path resolution to diverge from standard POSIX/OS behavior.PR Fixed
..resolved to the wrong path:path.Cleaneliminated<symlink>/..lexically instead of following the symlink first and then resolving..from the target directory (e.g.,/ln/../fwhereln -> x/yresolved to/finstead of/x/f)..and..:..(e.g.,/missing/..) were silently collapsed instead of returningENOENT..,.., or a trailing/(e.g.,/file/..,/file/.,/file/) were not rejected withENOTDIR.MODE_MASK_X) on intermediate directories before..was bypassed.ENOENT/EACCESinstead ofENOTDIR: Traversing through a non-directory component (e.g.,/file/sub) now checksTypeDirectorybefore permission/lookup and consistently returnsENOTDIR.ELOOPon valid paths: Tracking visited symlink inodes in a set caused valid paths traversing the same directory symlink multiple times (e.g.,/ln/../../ln/../f) to fail withELOOP. Replaced with a symlink hop counter (limit 40).subdirchecks are now enforced step-by-step on the resolved path (allowing ancestor traversal during the walk and requiring the final resolved target to stay within allowed subdirs), preventing escapes via symlinks,.., or stale dentry cache entries.