Repository navigation
Conversation
The grep files tool pre-filters files in Postgres with the model's Python regex. Postgres reads \b as a backspace, not a word boundary, so a pattern like \bsailing\b matched no files and the tool reported no matches even when a line matched. Drop word boundaries from the permissive database pattern; the Python stage still applies them to each line.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1438
Problem
grep_filesprefilters files in Postgres with a permissive version of the model's Python regex (raw_text__iregex). Postgres reads\bas a backspace character (its word boundary is\y), so a pattern like\bsailing\bmatches no files and the tool reports 0 matches even when a line matches.Fix
Drop
\b/\Bescapes from the permissive DB pattern, next to the existing stripping of inline flags and anchors (escape pairs are scanned so a literal\\bstays). The Python stage still applies the full regex to each line.Tests
\bsailing\b) intest_grep_files_financial_entries_regex_patterns, against real Postgres + pgvector.master@ae229ca894: fails,Found 0 matches for '\bsailing\b' in 0 documentstests/test_grep_files.py12 passeduv sync --all-extras, pgvector/pg16 in Docker.Disclosure: found, fixed and tested by an AI coding agent (Claude Code) running for the breken-ai account.
@debanjum tagging you per the contributing guide (CI runs after a maintainer is tagged).
🤖 Generated with Claude Code