Skip to content

refactor: share AuthoredComment impl via macro for Comment and PrComment - #55

Merged
kipyin merged 1 commit into
mainfrom
cloud/share-authored-comment-macro-dab3
Oct 7, 2026
Merged

kipyin merged 1 commit into
mainfrom
cloud/share-authored-comment-macro-dab3

Conversation

@kipyin

@kipyin kipyin commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Summary

AuthoredComment trait
  impl_authored_comment!(Comment)
  impl_authored_comment!(PrComment)

Duplicate author_login / created_at_str bodies for issue Comment and PrComment are generated from one impl_authored_comment! macro in src/api/mod.rs.

Evidence

  • After: cargo fmt --check, cargo clippy --all-targets --locked -- -D warnings, and cargo test --locked all pass locally.

Merge Danger

Door: two-way

Blast Radius: internal-only

Open in Web Open in Cursor 

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Approved. Cursor Security Agent completed with no findings requiring human review; Cursor Bugbot was not present, and this is a bounded internal refactor of identical AuthoredComment impls.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@kipyin
kipyin merged commit bd124af into main Oct 7, 2026
4 checks passed
@kipyin
kipyin deleted the cloud/share-authored-comment-macro-dab3 branch October 7, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants