[arpitjain099]

handleNewEvent registers the event in h.entries first, then four error paths return without calling deleteEvent: no broker address annotation, no AES key, a correlation id failure, a dispatch failure. Each one leaves a proxiedRequest holding the request's ResponseWriter in the map for the life of the pod. Only the reply and timeout paths clean up.

Moving the cleanup into a defer after addEvent covers every return. The new test posts five events at a broker that is not listening: 5 entries are left behind before the change, 0 after.

Proposed Changes

• 🐛 Unregister the proxied request with a defer, so every return from handleNewEvent removes it from h.entries

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

The RequestReply ingress no longer keeps a request registered after it fails, so failed requests stop accumulating in memory.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arpitjain099
Once this PR has been reviewed and has the lgtm label, please assign arsenetar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Welcome @arpitjain099! It looks like this is your first PR to knative/eventing 🎉

[knative-prow]

Hi @arpitjain099. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.