Skip to content

Let Renovate propose livekit/gstreamer revision rebuilds - #552

Merged
biglittlebigben merged 1 commit into
mainfrom
benjamin/renovate-gstreamer-revisions
Nov 5, 2026
Merged

biglittlebigben merged 1 commit into
mainfrom
benjamin/renovate-gstreamer-revisions

Conversation

@biglittlebigben

Copy link
Copy Markdown
Contributor

livekit/gstreamer publishes rebuilds of a GStreamer release with a revision number
(1.28.7-1-dev, 1.28.7-2-dev). The .gst-version custom manager only accepted
X.Y.Z-dev tags and compared versions as semver, which reads -2 as a prerelease
ranked below 1.28.7, so Renovate never proposed a rebuild.

  • matchStrings and extractVersionTemplate accept an optional -N revision.
  • Regex versioning reads the revision as a build number, so
    1.28.7 < 1.28.7-1 < 1.28.7-2 < 1.28.8.

A local renovate --platform=local --dry-run=lookup now proposes 1.28.7 → 1.28.7-2
as a patch update.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread renovate.json
],
"matchStrings": ["^(?<currentValue>\\d+\\.\\d+\\.\\d+)"],
"extractVersionTemplate": "^(?<version>\\d+\\.\\d+\\.\\d+)-dev$",
"matchStrings": ["^(?<currentValue>\\d+\\.\\d+\\.\\d+(?:-\\d+)?)"],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Scanner misses GStreamer revision updates

When matchStrings enables a revision update, the scanner base image stays pinned to 1.28.7-dev. Scanner builds then use the old GStreamer image instead of the revision used by ingress.

Learn more

The scanner has a hardcoded GStreamer base-image tag because its build receives no GSTVERSION argument. Renovate's custom manager updates only .gst-version. Once it accepts revisions, a revision-only PR can pass scanner builds without testing the GStreamer image selected for ingress. The hardcoded tag could already drift on a normal version bump; revision updates create another way to reach that mismatch.

Example: With .gst-version at 1.28.7, Renovate proposes 1.28.7-2. Ingress builds from 1.28.7-2-dev, but the scanner still builds from 1.28.7-dev.

Recommended fix: Update the scanner base image in the same Renovate PR, or make the scanner build consume .gst-version without a second hardcoded tag. Verify both base images use the same revision after a revision-only update.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@biglittlebigben
biglittlebigben merged commit 1ffb229 into main Nov 5, 2026
10 checks passed
@biglittlebigben
biglittlebigben deleted the benjamin/renovate-gstreamer-revisions branch November 5, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants