Repository navigation
utils: compare MetricsBatch str_data indexes without narrowing to int - #1946
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 72d28e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paulwe
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetricsBatchBuilder.Mergechecks each wirestr_dataindex againstlen(str_data)after converting theuint32index toint. On 32-bit builds an index of 2^31 or more turns negative and passes the check, and the lookup then goes out of range. Both index helpers now compare inuint64. 64-bit builds behave the same as before.Tests
A new subtest in
TestMetricsBatchBuildermerges time series and events with0xffffffffindexes. It fails without the fix in a linux/386 build and passes with it. The fullutilspackage passes under 386.Not verified
GOARCH=arm.🤖 Generated with Claude Code