Skip to content

clean stale, unused branches #642

Closed
Closed

Description

@zhaozg

There are a lots of branch to fix issues or try new features, but they too old, and I think it is unused anymore.

I have remove some merged branches, and others I can't make up mind.

So, we need do somethings, branch owners please delete them if unused, or do discuss for that.

branch safe to delete vote
clean-dns Yes +1
coro-error
error-redo
feat/bump_luajit_21 Yes +1
fix-luvi
fix/exec_run_loop_after_close Yes +1
fix/use_c_lua_dump Yes +1
fixes/add_32bit_build Yes +1
fixes/another_try_at_lgtm Yes +1
fixes/find_thread_library Yes +1
fixes/lj_vmmath Yes +1
fixes/luv_now_update_time Yes +1
fixes/propogate_raw_error Yes +1
lightuserdata
luvi-build Yes +1
schema
travis/test Yes +1
update-all-the-things Yes +1
upstream-cwd-fix Yes +1
uv-update-1.0.0 Yes +1

schema need talk about.

zhaozg +1 for deletable branchs.

Keep listening voice from @luvit/luvit-admin and contributors.

@Bilal2453 give options, and I narrow it. delete uv-update-1.0.0,upstream-cwd-fix, luvi-build are safe, see comment

Activity

  1. Bilal2453 commented on Apr 2, 2023

    @Bilal2453
    Contributor

    All current branches are safe for deletion as they have been merged except for 6: lightuserdata, coro-error, uv-update-1.0.0, upstream-cwd-fix, luvi-build, fix-luvi. If that helps.

    note: I looked at fix-luvi, which updates luajit and libuv to a currently outdated version, removes lua-compat-5.3, and manually does Lua 5.2/5.3 compatibility checks (for a couple of things). Doesn't seem applicable in current luvi/luv.

  2. zhaozg commented on Apr 2, 2023

    @zhaozg
    MemberAuthor

    uv-update-1.0.0 should be delete, now we already libuv v1.x.
    upstream-cwd-fix should be delete, which already solved on 2014-10-17, upstream libuv bug.
    luvi-build should be delete, which already merged on 2018-04-24 by Tim Caswell.

  3. locked and limited conversation to collaborators on Apr 2, 2023
  4. converted this issue into a discussion #643 on Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions