Skip to content

[codex] Enable dependency validation by default - #100

Open
wangxiaoyou1993 wants to merge 1 commit into
masterfrom
codex/dependency-validation-default-true
Open

wangxiaoyou1993 wants to merge 1 commit into
masterfrom
codex/dependency-validation-default-true

Conversation

@wangxiaoyou1993

Copy link
Copy Markdown
Member

Summary

  • Enable dependency validation by default for new Mage chart installs.
  • Add cleanupJob.suspend so cluster lifecycle controllers can pause future cleanup runs without deleting the CronJob.
  • Preserve explicit dependency-validation opt-out and missing-map --reuse-values compatibility.
  • Bump the chart version from 0.2.17 to 0.2.18.

Behavior

dependencyValidation.enabled now defaults to true. Setting it to false still suppresses the validation init container. Releases upgraded with reused values that do not contain the map remain disabled until explicitly enabled.

When cleanupJob.enabled is true, cleanupJob.suspend renders to Kubernetes CronJob spec.suspend. It defaults to false.

Validation

  • helm unittest charts/mageai: 28/28 passed.
  • helm lint charts/mageai: passed, with the existing warning that local dependency chart directories are absent.
  • git diff --check: passed.

Tests

  • Default dependency validation enabled.
  • Explicit dependency validation disabled.
  • Missing dependency-validation map compatibility.
  • Cleanup CronJob disabled, enabled/unsuspended, and enabled/suspended states.

Companion Change

The mage-cloud-backend PR uses cleanupJob.suspend for cluster stop/resume behavior.

@wangxiaoyou1993

Copy link
Copy Markdown
Member Author

Companion backend lifecycle change: https://github.com/mage-ai/mage-cloud-backend/pull/400

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant