Repository navigation
[codex] Enable dependency validation by default - #100
Open
wangxiaoyou1993 wants to merge 1 commit into
Open
wangxiaoyou1993 wants to merge 1 commit into
wangxiaoyou1993 wants to merge 1 commit into
Conversation
Member
Author
|
Companion backend lifecycle change: https://github.com/mage-ai/mage-cloud-backend/pull/400 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanupJob.suspendso cluster lifecycle controllers can pause future cleanup runs without deleting the CronJob.--reuse-valuescompatibility.0.2.17to0.2.18.Behavior
dependencyValidation.enablednow defaults totrue. Setting it tofalsestill suppresses the validation init container. Releases upgraded with reused values that do not contain the map remain disabled until explicitly enabled.When
cleanupJob.enabledis true,cleanupJob.suspendrenders to Kubernetes CronJobspec.suspend. It defaults to false.Validation
helm unittest charts/mageai: 28/28 passed.helm lint charts/mageai: passed, with the existing warning that local dependency chart directories are absent.git diff --check: passed.Tests
Companion Change
The
mage-cloud-backendPR usescleanupJob.suspendfor cluster stop/resume behavior.