Repository navigation
Default cleanup job to application node selector - #102
Merged
Merged
Conversation
tommydangerous
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the cleanup CronJob inherit the top-level
nodeSelectorused by the Mage application pods unless a non-emptycleanupJob.nodeSelectoroverride is configured.Why
PR #101 added an independent cleanup-job selector. For the common case, operators expect the cleanup workload to follow the same node-placement policy as the deployment without repeating the label map in two values.
Behavior
Precedence is:
cleanupJob.nodeSelectorapplies only to the cleanup CronJob.nodeSelector.This intentionally changes cleanup-job placement for installations that already configure a top-level
nodeSelector: the cleanup CronJob will now use that selector by default.Implementation
0.2.18to0.2.19.Testing
helm lint charts/mageaihelm unittest charts/mageai— 29 tests passed