Repository navigation
Stop screen readers announcing "connecting" when Web Chat starts - #6016
Merged
Merged
Conversation
added 3 commits
November 4, 2026 00:34
The toaster announced every notification it had not announced yet, including the connectivity status notification, which it never renders. At start-up, screen readers heard the raw word "connecting". Loop over the rendered notifications instead, and add toast/liveRegion.renderedOnly.html.
Tests that read or show the live region expected the connectivity
status notification ("connecting" or "connected") first. Remove it
from 22 tests' expectations and regenerate the 63 snapshots that show
the live region; nothing else changed in them.
Eugene (OEvgeny)
marked this pull request as ready for review
November 4, 2026 19:25
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 4, 2026 19:25
William Wong (compulim)
previously approved these changes
Nov 5, 2026
added 2 commits
November 4, 2026 23:21
…nnecting' activityStatus.longSend.echoBack.html and activityStatus.longSend.sharedKey.html (added in #6013) expected the toaster's 'connecting' first. Drop it; sharedKey's live region is now empty. Regenerate both snapshots: only the 'connecting' line is gone.
Eugene (OEvgeny)
dismissed
William Wong (compulim)’s stale review
via
November 5, 2026 07:39
729c88c
Collaborator
Author
|
Merged
Their 2 snapshots changed only in the live region. Nothing else changed since your approval; without this, merging would turn |
William Wong (compulim)
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
The toaster queued every notification to the live region, including the connectivity status notification, which only the connectivity status bar shows and which is deliberately silent while Web Chat starts (#5946). The toaster now announces only the notifications that its toast middleware renders, expanded or collapsed.
Design
connectivitystatusid a second time: a host whosetoastMiddlewareshows that notification as a toast still gets it announced, and one it hides (returnsfalse) is no longer announced.role="log"instead of the queued copy: that changes how every toast is announced, a separate change.Specific Changes
BasicToaster.js: loop oversortedNotificationsWithChildren(rendered toasts) instead of every notificationtoast/liveRegion.renderedOnly.html: snapshot 1, the live region (bottom) has only the toast text, no "connecting"ariaNotify()calls no longer expect the leading "connecting" or "connected"; the 63 snapshots that show the live region lose that one line and nothing else.changelog/<PR#>-<slug>.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed