[Eugene (OEvgeny)]

Fixes #5613

Changelog Entry

Fixed

• Fixed #5613, Adaptive Card input errors read as part of the input's name, in PR #6021, by @OEvgeny

Description

Adaptive Cards puts the validation error's ID in the input's aria-labelledby, so screen readers read "Role Please select the role Project Manager" as its name; it never sets aria-invalid and keeps the ID after the error is gone. A new card mod moves the error to aria-describedby, sets aria-invalid="true" while it is shown, and drops IDs that point to nothing. Not yet checked with Narrator or NVDA.

Design

• The long-term fix is upstream, in Input.getAllLabelIds() (still in adaptivecards 3.0.6); the mod does nothing once the error is no longer in the name.
• Not aria-errormessage: screen reader support is still uneven; aria-describedby is read everywhere.
• Undo restores an attribute only if Adaptive Cards has not rewritten it (validation rewrites aria-labelledby in place).
• Runs like the other mods: after render and on card DOM changes, one query per input.

Specific Changes

• useInputErrorShouldBeDescriptionModEffect.ts: new mod, used by AdaptiveCardRenderer.tsx

• setOrRemoveAttributeIfFalseWithUndoIfUnchanged.ts: compare-and-restore undo

• hack.inputErrorShouldBeDescriptionMod.*.html, text, toggle, multi-select: snapshot 1 error (label is the name, error the description, invalid), 2 cleared (no dangling ID); text submits 2×

• ….choiceSet.filtered.html: snapshot 1, text box described by the error, invalid

• I have added tests and executed them locally

• I have added .changelog/<PR#>-<slug>.md

• I have updated documentation

Review Checklist

This section is for contributors to review your work.

• Accessibility reviewed (tab order, content readability, alt text, color contrast)
• Browser and platform compatibilities reviewed
• CSS styles reviewed (minimal rules, no z-index)
• Documents reviewed (docs, samples, live demo)
• Internationalization reviewed (strings, unit formatting)
• package.json and package-lock.json reviewed
• Security reviewed (no data URIs, check for nonce leak)
• Tests reviewed (coverage, legitimacy)

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.