Repository navigation
Explain the emulated screen reader action in the primary action tests and remove the NVDA test - #6022
Merged
Merged
Conversation
added 2 commits
November 5, 2026 13:43
… NVDA test Narrator (UI Automation Invoke) and NVDA (IAccessible2 doAction) both run the browser's accessibility default action, which Chromium turns into a click on the active descendant. The NVDA test clicked the active descendant's first child, which is aria-hidden and unreachable by any screen reader, so it only repeated the Narrator test.
Eugene (OEvgeny)
marked this pull request as ready for review
November 6, 2026 06:49
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 6, 2026 06:49
William Wong (compulim)
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
In #6020, the tests emulate a screen reader's "primary action" with
click(), and William Wong (@compulim) asked what they test. Narrator (UI Automation Invoke) and NVDA's ENTER in browse mode (IAccessible2doAction) both ask the browser for the accessibility default action, which Chromium turns into a click on the active descendant itself. Neither WebDriver nor the Chrome DevTools Protocol can run that action, so the tests have to emulate it.The
.nvda.htmltest clicked the active descendant's first child. That child isaria-hidden, so no screen reader can reach it: the path only existed with #4041's markup. The test only repeated the Narrator test.Specific Changes
focusAttachment.screenReaderPrimaryAction.windowsNarrator.htmlandpart-grouping/primaryAction.windowsNarrator.html: the WHEN comment now names the real screen reader call and says whyclick()emulates itRemoved
focusAttachment.screenReaderPrimaryAction.nvda.htmland its 3 snapshotsNo product change
I have added tests and executed them locally
I have added
.changelog/<PR#>-<slug>.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed