Skip to content

Preserve first timestamp after fallback #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harsh (Mr-KnightCLI) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Preserve first timestamp after fallback #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b33eadf
Fix first event timestamp fallback
Mr-KnightCLI Oct 20, 2026
9fe8113
Test first timestamp after an early fallback lookup
Mr-KnightCLI Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions parser/src/main/java/com/microsoft/gctoolkit/parser/jvm/PreUnifiedDiarizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,8 @@ public boolean diarize(String line) {

@Override
public DateTimeStamp getTimeOfFirstEvent() {
if (timeOfFirstEvent == null)
timeOfFirstEvent = new DateTimeStamp(0.0d);
return timeOfFirstEvent;
// Keep the fallback transient so a timestamp found on a later line can still be recorded.
return timeOfFirstEvent == null ? new DateTimeStamp(0.0d) : timeOfFirstEvent;
Comment thread
karianna marked this conversation as resolved.
Resolved
}

private void timeOfFirstEvent(String line) {
Expand Down Expand Up @@ -1047,4 +1046,5 @@ private void setGCCause(String gcCause) {
}
}
}
}
}

25 changes: 25 additions & 0 deletions parser/src/test/java/com/microsoft/gctoolkit/parser/PreUnifiedDiarizerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
package com.microsoft.gctoolkit.parser;

import com.microsoft.gctoolkit.parser.jvm.PreUnifiedDiarizer;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;

class PreUnifiedDiarizerTest {

@Test
void earlyTimestampLookupDoesNotPreventRecordingFirstEvent() {
PreUnifiedDiarizer diarizer = new PreUnifiedDiarizer();
assertEquals(0.0, diarizer.getTimeOfFirstEvent().toSeconds());

diarizer.diarize("1.250: [GC (Allocation Failure) 100K->50K(200K), 0.001 secs]");
assertEquals(1.250, diarizer.getTimeOfFirstEvent().toSeconds());
assertEquals(1.250, diarizer.getDiary().getTimeOfFirstEvent().toSeconds());

diarizer.diarize("2.500: [GC (Allocation Failure) 100K->50K(200K), 0.001 secs]");
assertEquals(1.250, diarizer.getTimeOfFirstEvent().toSeconds());
assertEquals(1.250, diarizer.getDiary().getTimeOfFirstEvent().toSeconds());
}
}
Loading