Skip to content

deps: update mfm-js to 0.27.0 - #18017

Merged
kakkokari-gtyih merged 2 commits into
misskey-dev:developfrom
kakkokari-gtyih:deps-update-mfmjs-r27
Oct 14, 2026
Merged

kakkokari-gtyih merged 2 commits into
misskey-dev:developfrom
kakkokari-gtyih:deps-update-mfmjs-r27

Conversation

@kakkokari-gtyih

Copy link
Copy Markdown
Member

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions Bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Oct 14, 2026
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: misskey-dev/misskey/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 01704161-d73e-43ea-8387-d79d074f3b87
📥 Commits

Reviewing files that changed from the base of the PR and between 83053ce and df69470.

📒 Files selected for processing: 1
  • packages/backend/test/unit/ReactionService.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

4つのパッケージでmfm-jsを0.26.0から0.27.0に更新しました。ReactionService.createのテスト用クエリビルダーモックにsetParametersを追加しました。

Changes: 依存関係更新とテスト調整

Layer / File(s) Summary
4パッケージの依存バージョン更新
packages/backend/package.json, packages/frontend-embed/package.json, packages/frontend-shared/package.json, packages/frontend/package.json
各パッケージのmfm-js依存バージョンを0.27.0に更新しました。
ReactionServiceテスト用モックの変更
packages/backend/test/unit/ReactionService.ts
クエリビルダーモックにsetParametersを追加し、その戻り値からexecuteがundefinedで解決するように変更しました。

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: samunohito

Merge Risk: ⚪ Minimal · up to df694

The test mock now follows the production query chain. No specific regression from the dependency update is established, so no actionable merge risk is identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning テンプレートの見出しはありますが、必須の What と Why の内容が未記入です。テスト結果も記載されていません。 What に変更内容と影響を記載し、Why に更新理由を記載してください。実施したテストと結果も Additional info に記載し、ローカル環境でテストした場合はチェックリストを更新してください。
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed タイトルは mfm-js を 0.27.0 に更新する主な変更を正確かつ簡潔に示しています。
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

依存の数字がひとつ進みます
backendにもfrontendにも
モックには段階が加わって
executeへとつながります
小さな更新、静かに完了です

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.26%. Comparing base (d543d8b) to head (df69470).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18017      +/-   ##
===========================================
+ Coverage    16.29%   26.26%   +9.97%     
===========================================
  Files         1161     1159       -2     
  Lines        39986    39773     -213     
  Branches     10999    10962      -37     
===========================================
+ Hits          6515    10447    +3932     
+ Misses       26710    23544    -3166     
+ Partials      6761     5782     -979     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

⚙️ Backend Diagnostics Report

Memory: After GC

(No significant changes)

V8 Heap Snapshot Statistics

Metric @ Base @ Head Δ MAD
$\color{gray}{\rule{8pt}{8pt}}$ Total 84 MB
± 5 KB
84 MB
± 11 KB
$\text{-40 KB}$
$\text{-0\%}$
12 KB
$\color{orange}{\rule{8pt}{8pt}}$ Code 24 MB 24 MB $\text{+616 B}$ 13 KB
$\color{red}{\rule{8pt}{8pt}}$ Strings 29 MB 29 MB $\text{-38 KB}$ 1 KB
$\color{cyan}{\rule{8pt}{8pt}}$ JS arrays 5.4 MB 5.4 MB 0 B 0 B
$\color{green}{\rule{8pt}{8pt}}$ Typed arrays 543 KB 543 KB 0 B 0 B
$\color{yellow}{\rule{8pt}{8pt}}$ System objects 2.2 MB 2.2 MB $\text{-168 B}$ 1.2 KB
$\color{violet}{\rule{8pt}{8pt}}$ Other JS objs 23 MB 23 MB $\text{+248 B}$ 180 B
$\color{pink}{\rule{8pt}{8pt}}$ Other non-JS objs 39 KB 39 KB 0 B 0 B

Download representative heap snapshot: base / head

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🖥 Frontend Diagnostics Report

Metric @ Base @ Head Δ MAD
Page-attributed memory 9.6 MB
± 14 KB
9.5 MB
± 11 KB
$\color{green}{\text{-104 KB}}$
$\color{green}{\text{-1.1\%}}$
18 KB

Only metrics showing significant changes are displayed.

View details

Requests by resource type
Type Requests Encoded bytes
Base Head Δ Base Head Δ
Document 2 2 0 33 KB 33 KB 0 B
Script 148 148 0 2.1 MB 2.1 MB $\color{orange}{\text{+880 B}}$
Stylesheet 58 58 0 284 KB 284 KB 0 B
Fetch 20 20 0 46 KB 46 KB 0 B
Image 10 10 0 254 KB 254 KB 0 B
Font 2 2 0 118 KB 118 KB 0 B
Other 9 9 0 421 KB 421 KB $\color{orange}{\text{+11 B}}$
V8 heap snapshot statistics
Metric @ Base @ Head Δ MAD
$\color{gray}{\rule{8pt}{8pt}}$ Total 11 MB
± 4.5 KB
11 MB
± 5.2 KB
$\text{+3.1 KB}$
$\text{+0\%}$
6.9 KB
$\color{orange}{\rule{8pt}{8pt}}$ Code 2.8 MB 2.8 MB $\text{-136 B}$ 2.8 KB
$\color{red}{\rule{8pt}{8pt}}$ Strings 1.2 MB 1.2 MB $\text{-276 B}$ 244 B
$\color{cyan}{\rule{8pt}{8pt}}$ JS arrays 113 KB 113 KB $\text{-16 B}$ 36 B
$\color{green}{\rule{8pt}{8pt}}$ Typed arrays 0 B 0 B 0 B 0 B
$\color{yellow}{\rule{8pt}{8pt}}$ System objects 0 B 0 B 0 B 0 B
$\color{violet}{\rule{8pt}{8pt}}$ Other JS objs 2 MB 2 MB $\text{+608 B}$ 343 B
$\color{pink}{\rule{8pt}{8pt}}$ Other non-JS objs 5 MB 5 MB $\text{+3.5 KB}$ 2.5 KB

Download representative heap snapshot: base / head

📦 Bundle Stats

Chunk size diff (0 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 5.9 MB 5.9 MB $\text{+440 B}$ $\text{+0\%}$
(other generated chunks) 2 MB 2 MB $\text{+440 B}$ $\text{+0\%}$
Startup chunk size (0 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 1 MB 1 MB $\text{+440 B}$ $\text{+0\%}$
(other generated chunks) 756 KB 757 KB $\text{+440 B}$ $\text{+0.1\%}$
(other) 283 KB 283 KB 0 B 0%

Startup chunks are the Vite entry for src/_boot_.ts and its static imports.

Bundles Modules Entries Imports Size
Static Dynamic Rendered Gzip Brotli
Base 469 2,855 21 10,334 333 10 MB 2.8 MB 2.4 MB
Head 469 2,855 21 10,334 333 10 MB 2.8 MB 2.4 MB
Δ 0 0 0 0 0 $\color{orange}{\text{+1.2 KB}}$ $\text{+295 B}$ $\text{+221 B}$
Δ (%) 0% 0% 0% 0% 0% $\text{+0\%}$ $\text{+0\%}$ $\text{+0\%}$

Open treemap HTML

@kakkokari-gtyih
kakkokari-gtyih marked this pull request as draft October 14, 2026 08:21
@kakkokari-gtyih
kakkokari-gtyih marked this pull request as ready for review October 14, 2026 08:39
@kakkokari-gtyih
kakkokari-gtyih merged commit d43954b into misskey-dev:develop Oct 14, 2026
41 of 42 checks passed
@kakkokari-gtyih
kakkokari-gtyih deleted the deps-update-mfmjs-r27 branch October 14, 2026 08:50
@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR

Projects

Development

Successfully merging this pull request may close these issues.

1 participant