Skip to content

Verify the Dockerfile's downloads against pinned SHA256 digests - #39

Merged
mlin merged 1 commit into
mlin:mainfrom
Wid-L-Hacker:conrad/pin-digests
Oct 28, 2026
Merged

mlin merged 1 commit into
mlin:mainfrom
Wid-L-Hacker:conrad/pin-digests

Conversation

@Wid-L-Hacker

Copy link
Copy Markdown
Contributor

The Dockerfile's builder stage downloads the SQLite amalgamation and the zstd release tarball and compiles them into the shipped library, with nothing checking that the downloaded bytes are what the version labels promise. This pins a SHA256 digest beside each version (SQLITE_SHA256, ZSTD_SHA256) and verifies it with sha256sum -c immediately after the download, so a corrupted, truncated, or substituted artifact fails the build instead of flowing into the release; the SQLite download also moves from http to https. The versions themselves are unchanged, and both digests were verified against fresh downloads from sqlite.org and the zstd GitHub release.

Sequencing: this is based on the #37 packaging branch and merges after #37. That ordering is what scopes it to two downloads — #37 removes the CMake-installer download in favor of the distro CMake, so the CMake-installer digest proposed in #38 has nothing left to attach to and is deliberately not included.

@mlin
mlin force-pushed the conrad/pin-digests branch from e2cc576 to 41f4154 Compare October 28, 2026 06:14
@mlin
mlin merged commit 11eacea into mlin:main Oct 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants