Repository navigation
Verify the Dockerfile's downloads against pinned SHA256 digests - #39
Merged
Merged
Conversation
mlin
force-pushed
the
conrad/pin-digests
branch
from
October 28, 2026 06:14
e2cc576 to
41f4154
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile's builder stage downloads the SQLite amalgamation and the zstd release tarball and compiles them into the shipped library, with nothing checking that the downloaded bytes are what the version labels promise. This pins a SHA256 digest beside each version (SQLITE_SHA256, ZSTD_SHA256) and verifies it with
sha256sum -cimmediately after the download, so a corrupted, truncated, or substituted artifact fails the build instead of flowing into the release; the SQLite download also moves from http to https. The versions themselves are unchanged, and both digests were verified against fresh downloads from sqlite.org and the zstd GitHub release.Sequencing: this is based on the #37 packaging branch and merges after #37. That ordering is what scopes it to two downloads — #37 removes the CMake-installer download in favor of the distro CMake, so the CMake-installer digest proposed in #38 has nothing left to attach to and is deliberately not included.