Repository navigation
fix(release): use install_steps for the cask quarantine hook - #25
Merged
Merged
Conversation
Contributor
|
Thanks! Tracked in the SDD graph:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Homebrew deprecated the
postflightblock in casks.brew updateprints this warning for thesddcask:GoReleaser writes the
postflightblock from thehooks.post.installfield. GoReleaser marks this field as deprecated. This change replaces it withhooks.post.install_steps. GoReleaser then writes apostflight_stepsblock.The hook does the same work as before. It removes the quarantine flag from the
sddbinary on macOS.{{ .StagedPath }}is a GoReleaser field. It renders as the Homebrew token{{staged_path}}.Test
goreleaser checkpasses with the latest GoReleaser image.postflight_stepsinCasks/sdd.rb.com.apple.quarantine.com.apple.quarantine.I did not test the real release job. The snapshot skips the upload to the tap.
Notes
version: "~> v2". It installs the newest GoReleaser v2 release. If an older release does not knowinstall_steps, pinversionto a newer v2 release.Casks/sdd.rbinnetworkteam/homebrew-tap.

Confidence Score: 5/5
The PR appears safe to merge; no blocking issue was found.Summary
Replaces the deprecated Homebrew cask hook in
.goreleaser.yamlwithinstall_steps.Reviews (1) · Last reviewed commit: "fix(release): use install_steps for the ..." · Reviewed by Greptile