Repository navigation
Fix/user grid - #420
Open
whaeck wants to merge 3 commits into
Open
Fix/user grid#420whaeck wants to merge 3 commits into
whaeck wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating the initial grid used for linearisation in RECONR, NJOY2016 uses a strategy in which it adds grid points based on the resonance energies and resonance widths. In addition to those points, it will also include user defined grid points and boundaries for resonance ranges (if resonances are present). These boundary points are split into 2 points by nudging the boundary point up and down so that a discontinuity is created.
NJOY2016 seems to always drop the last value of that grid, either the highest user defined point or the second point in the discontinuity of the last resonance boundary. Another issue found was that the user defined grid points were assumed to be sorted which could lead to some weirdness when they were not (only when there were no resonance parameters present).
This merge request fixes these issues and corrects the sorting function as well to fix a few edge cases (e.g. sorting was skipped if 2 or less values had to be sorted, even if they were not sorted, etc.)
Tests were updated since we now have the second point in the discontinuity appear in the test files.